Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda hash to mulled-hash utility #18938

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Oct 4, 2024

Despite the overlap in mulled-v1- naming, the v1_image_name in mulled.util is not actually used for conda v1 mulled hashes. Perhaps it should, since as far as I know, we never used the container mulled v1 hash for anything, but that's another issue.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1.  $ mulled-hash --hash conda bedtools=2.30.0,samtools=1.9
       mulled-v1-ca195b12c14e35565e393a2d07f2deac7610d8126cc3460d217504efd11d4347

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add doc tests to the main function?

@jmchilton
Copy link
Member

This has become conflicted with the merge of #18522 - also the way you're doing the hash the mypy typing is giving me some problems. I'd recommend rebasing on dev and just doing a if/else chain on that hash.

@jmchilton jmchilton marked this pull request as draft November 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment