Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal Tabs #943

Closed
wants to merge 8 commits into from
Closed

Add horizontal Tabs #943

wants to merge 8 commits into from

Conversation

bw8686
Copy link
Contributor

@bw8686 bw8686 commented Aug 27, 2024

This requires 1 new strings for settings (that is if you choose to keep the setting there)
zen-vertical-tabs-button which could be "Vertical Tabs"

Feel free to edit to fit zen's settings page.

@bw8686
Copy link
Contributor Author

bw8686 commented Aug 27, 2024

This is good to merge now if you are ok with the settings and stuff like that.

1 similar comment
@bw8686

This comment was marked as duplicate.

@bw8686
Copy link
Contributor Author

bw8686 commented Aug 27, 2024

me when the github mobile app is total garbage and sends my comment twice

@mauro-balades
Copy link
Member

Ill merge it once it's 100% implemented, there seems to be issues with pinned tabs

@bw8686
Copy link
Contributor Author

bw8686 commented Aug 28, 2024

this can be checked out now

@Neintonine
Copy link

Hei, could you perhaps squash the commits to one commit? That would clear up the commit log, once the PR is merged. ;)

@zptan
Copy link

zptan commented Sep 1, 2024

Hei, could you perhaps squash the commits to one commit? That would clear up the commit log, once the PR is merged. ;)

IIRC, github CI workflow can be configured to squash commits + rebase when a PR is being merged.

@mauro-balades
Copy link
Member

You (I) can squash and merge directly from the PR

@3kh0
Copy link

3kh0 commented Sep 5, 2024

Please merge this as I the vertical tabs to be the only reason that I do not main zen browser. :D

@alexjsteffen
Copy link

Yes, I am also patiently waiting for this feature!

@zptan
Copy link

zptan commented Sep 7, 2024

this can be checked out now

@mauro-balades Friendly ping, it seems this PR is ready for review.

@mauro-balades
Copy link
Member

Not as easy...

  1. The implementation is pretty bad (it uses absolute values, it may not work if UI changes or screen size changes)
  2. My current plans aren't really helping with horizontal tabs (Tree style view)
  3. Some things still dont work (like scrolling pinned tabs)
@FrostedVolcano
Copy link

FrostedVolcano commented Sep 8, 2024

Yes please.
Can some one point the codes to be so that I can add to chrome.css to get horizontal tabs for myself.

@B1ack3ye
Copy link

Any updates on this?

@p0358
Copy link

p0358 commented Sep 15, 2024

Personally for the time being Sidebery with auto-hiding sidebar seems to be a really nice connection. That extension has the most features, is snappy, though sadly doesn't support some Zen-specific things like triggering tab splitting

@zptan
Copy link

zptan commented Sep 16, 2024

Horizontal Tab gets most votes in Discussion, we hope it could happen.

@AvinashK13
Copy link

Loving the browser so far 👏🏼
Hope horizontal tabs gets implemented soon

@javaskript
Copy link

This is not planned to be implemented anytime soon, guys. Posted a few days ago on Zen's FAQ that vertical tabs are an essential part of their philosophy:

Zen Browser will not support horizontal tabs in the near future. The decision to focus on Vertical Tabs is a core design choice, with the entire Zen Browser experience built around this concept. This approach is intended to maximize screen space and improve navigation, making vertical tabs an essential part of Zen’s philosophy.

A shame, I'm not interested in using a browser that exclusively has vertical tabs, I am much too used to the standard horizontal tabs that 99% of browsers feature.

@B1ack3ye
Copy link

Zen Browser will not support horizontal tabs in the near future. The decision to focus on Vertical Tabs is a core design choice, with the entire Zen Browser experience built around this concept. This approach is intended to maximize screen space and improve navigation, making vertical tabs an essential part of Zen’s philosophy.

That's disappointing to hear. The browser really had great potential for me, and it was finally a Firefox fork that genuinely surprised me and made me consider using it as my main browser.
Now that horizontal tabs won't be implemented anytime soon, and it sounds like they likely never will due to Zen's philosophy, it's probably time for me to look elsewhere for a good browser.

@probablykasper
Copy link

For me, horizontal tabs would maximize screen space and improve navigation so I hope it could be considered

@alexjsteffen
Copy link

Please see my comment here about an alternative proposal for horizontal tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet