Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listview and listviewitem roles to support interactive lists of interactive widgets, cards, tiles, etc. #2328

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Sep 15, 2024

Closes #2036

Related issues:

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests:
  • "user agent MUST" tests:
  • Browser implementations (link to issue or commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations?
  • Related APG Issue/PR:
  • MDN Issue/PR:

Preview (#listview) (#listviewitem) | Diff

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 82f61ff
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66f11ade1ac8230008e648d8
😎 Deploy Preview https://deploy-preview-2328--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mcking65 mcking65 changed the title Add listview and listviewitem roles to support interactive lists Sep 16, 2024
@mcking65
Copy link
Contributor Author

@jnurthen @spectranaut

How do I find the lines that are generating the failures? When I go to the details for the check, I can't find where the actual failure is shown.

@jnurthen
Copy link
Member

@mcking65 Your PR has introduced a lot of spacing changes which makes it very difficult to evaluate the problem.

A <code>listview</code> can scroll in any direction as users move focus.</code>
Items can be arranged in a single column, a single row, or in multiple columns or rows.
Authors SHOULD indicate whether the order of the collection is presented horizontally or vertically with <pref>aria-orientation</pref>.
For example, if a set of twenty cards is presented in a vertical list that is wrapped into five columns that contain four cards, authors SHOULD set <pref>aria-orientation</pref> to <code>vertical</code>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: The value "vertical" would inform screen reader users only that they can use up and down arrow keys to muve through the list. To signal to the users that they can move vertically and horizontally - such as the case in a dashboard - would require a new value for "aria-orientation" in addition to vertical and horizontal. It could be "gridlike", "all" or something similar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first thought was that this could provide support for languages that are vertical. I wonder if aria-orientation could have a default value of any (or similar) but could also accept author provided values of horizontal or vertical?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants