Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] VReplication Merge Workflows: add heuristic to handle valid duplicate key errors caused by unique key columns. #17074

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Oct 25, 2024

Description

The core functionality that this PR adds is a backoff mechanism in case of ERDupKey errors. The stream that has the error, will wait for a specific period and retry, hoping that the other stream has moved forward. (See the related issue for when the error can happen).

Todos

  • Identify merge workflows, for optimization, so that we don't backoff when it is not possible for another stream to unblock it!
  • During backoff if a previous commit was dropped, apply it. When two row events get merged into a single transaction because of a dropped commit, and it is required that the first one has to be applied to unblock the erroring event which is part of the backoff, we end up with a deadlock and this backoff finally times out.
  • Make batching dynamic per-stream so that it can be temporarily turned off during the backoff. Same reason as the previous item.
  • Test coverage

Related Issue(s)

#14296

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Oct 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.
@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 25, 2024
@rohit-nayak-ps rohit-nayak-ps self-assigned this Oct 25, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 25, 2024
@rohit-nayak-ps rohit-nayak-ps removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 45.16129% with 85 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (78f7db2) to head (79178e1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../vt/vttablet/tabletmanager/vreplication/vplayer.go 43.33% 85 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17074      +/-   ##
==========================================
+ Coverage   67.32%   67.33%   +0.01%     
==========================================
  Files        1569     1569              
  Lines      252552   252705     +153     
==========================================
+ Hits       170032   170171     +139     
- Misses      82520    82534      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…se workflow

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…testing changes/comments. ExecWithRetry enhanced with a timeout instead of the backoff function for now. Need to see if this can stay or needs to be changed

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…ing enabled

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…ents added for debugging. Code needs better organization

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…the following vdiff to fail randomly. Only run in vtctldclient to avoid flakiness

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…locally on Mac with installed version

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work Type: Bug
1 participant