Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api/atom] refactor key-value lookup path types for TS 4.3+ #303

Closed
postspectacular opened this issue Jul 1, 2021 · 1 comment
Closed

[api/atom] refactor key-value lookup path types for TS 4.3+ #303

postspectacular opened this issue Jul 1, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@postspectacular
Copy link
Member

Some of the path-lookup related utility types in thi.ng/api & thi.ng/atom can & should be simplified using the newly available syntax and TS compiler features for variadic tuples. The current (older) implementations of these types is causing compiler errors in the latest TS 4.3.x and forced me to temporarily disable support for path lengths > 6 in thi.ng/atom's IReset and ISwap interfaces...

The relevant types needing to be updated/replaced are:

  • KeysN
  • ValN
  • Path0...Path8 & DeepPath
  • possibly any other related/referenced helper types
@postspectacular postspectacular added the help wanted Extra attention is needed label Jul 1, 2021
postspectacular added a commit that referenced this issue Jul 1, 2021
@postspectacular
chore(atom): #303 temp. disable deep paths
7c64763 
- temporarily disable path lengths > 6 due to TS 4.3.x compiler
causing recursion errors during inferencing
postspectacular added a commit that referenced this issue Jul 1, 2021
@postspectacular
docs(atom): update readme (note about #303)
3b6721b
@postspectacular
Copy link
Member Author

Oops, just realized that I'd already created an issue for this previously... Let's move further discussion/updates to #294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
1 participant
@postspectacular