Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary provide methode of PokedexClient #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary provide methode of PokedexClient #73

wants to merge 2 commits into from

Conversation

houssem85
Copy link

Types of changes

Remove unnecessary provide methode of PokedexClient in hilt NetworkModule because this class is not a third party class, his constructor annotated with @Inject define how to instantiate it.

This is my first contribution in open source projects, eagerly waiting for your evaluation.
@amansinghrajpoot
Copy link

@houssem85 There are conflicts in your code. I don't think huge changes even if they are just refactoring should be proposed in one go. You can create multiple PRs. It becomes more easier for review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@houssem85 @amansinghrajpoot