-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Synology [DSM 7] #291
base: master
Are you sure you want to change the base?
Conversation
checks DISTRO variable in getPlexVersion and parseVersion
change cut to return field 2 and 3 instead of just 2
update plexupdate.sh to automatically determine if we're running on a synology
add ability to detect if running on synology in installer.sh
add spaces before closing brackets
changed spaces to tabs
remove check for plexpass version as now public versions also use new build versions.
BUILD="linux-${ARCH}" is already done at line 56 Co-Authored-By: Alex Malinovich <alexmalinovich@gmail.com>
Add link to "How to add Plex’s package signing public key to Synology NAS Package Center"
use -s option "do not echo input coming from a terminal" to hide password
Use new crontab file file in cron.d instead of cron.daily to support more devices
Easier to see what /etc/cron.d/plexupdate will look like
AUTOSTART is needed on synology
I made updates to the installer script, but have not tested them |
plexupdate.sh
Outdated
if [ ${RET} -eq 1 ]; then | ||
if [ "${DISTRO}" = "synology" || "${DISTRO}" = "synology-dsm7" ]; then | ||
error "On Synology devices, you need to add Plex's public key to Package Center. If you have not done so, follow the instructions at https://support.plex.tv/articles/205165858-how-to-add-plex-s-package-signing-public-key-to-synology-nas-package-center/" | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DSM7 package manager doesn't appear to have an interface for adding Plex's public key any more, so this may only be required for DSM6.
An odd issue I encountered was that Plex appeared to be stopped, re-installed, and started again on each cron run even if a new version was not available. I originally thought the version parsing / comparison was the issue, but instead it appears to have resolved itself 🤷 . There was an inconsistency though between the version numbers parsed from filenames (e.g |
This builds on #247 to support changes in DSM7
synology-dsm7
PlexMediaServer
(spaces removed)systemctl
command is available on DSM7, so conditionals for finding the start command to run needed to be reordered