Don't throw arbitrary iterators at sized_sentinel_for
#5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split `_Idl_distance` into Ranges and pre-Ranges flavors. Who put their Ranges in my peanut butter??!? * Move `_STD _Idl_dist_min` into `ranges` for consistency. Fixes VSO-2285862 and VSO-2285916.
|
Hahaha - I noticed the missing namespace-closing comment in the internal PR without having run clang-format outside of my brain. 🧠 💯 🧙♂️ |
VS Code has been driving me nuts the last couple of updates deciding to not format-on-save seemingly at random. I suppose I shouldn't complain, I at least figured out how to stop the C++ extension from deciding |
microsoft#5015 unskipped these, they now go through the same old codepath.
StephanTLavavej
approved these changes
Oct 20, 2024
|
Thanks for fixing this up! 🛠️ 🪄 🐈⬛ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Idl_distanceinto Ranges and pre-Ranges flavors. Who put their Ranges in my peanut butter??!?_STD _Idl_dist_minintorangesfor consistency.Fixes VSO-2285862 and VSO-2285916. (Currently validating.)
This is a mirror of MSVC-PR-586447. (I created the mirror PR early so I can verify this fixes things that #5015 broke in RWC.)