Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning C26818 about switch statements needing default cases #4715

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Fix warning C26818 about switch statements needing default cases #4715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
057fa3b
Always `break` at the end of a `switch`.
StephanTLavavej Jun 8, 2024
224f95f
Add test coverage for warning C26818 "Switch statement does not cover…
StephanTLavavej Jun 8, 2024
882a13a
`<xlocmon>`: Fix `money_base::pattern` warnings.
StephanTLavavej Jun 8, 2024
54cf227
`<format>`: Fix `_Num_bytes` warning.
StephanTLavavej Jun 8, 2024
9350b30
`<format>`: Fix more warnings by adding empty `default: break;`.
StephanTLavavej Jun 8, 2024
bdf44e7
Fix `range_formatter` warnings, add test coverage.
StephanTLavavej Jun 8, 2024
0b293a0
Fix `chrono::parse` warning, add test coverage.
StephanTLavavej Jun 8, 2024
ff05781
Fix `regex` warning, add test coverage.
StephanTLavavej Jun 8, 2024
5453bdf
Use `_STL_UNREACHABLE`.
StephanTLavavej Jun 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix chrono::parse warning, add test coverage. 
This is covered by the new test.

The empty `default: break;` is used, i.e. making it `abort()` causes tests to fail.
  • Loading branch information
@StephanTLavavej
StephanTLavavej committed Jun 8, 2024
commit 0b293a07177bf6f5f5e10de3eb1906511fa25a77
2 changes: 2 additions & 0 deletions stl/inc/chrono
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4177,6 +4177,8 @@ namespace chrono {
case '+':
++_First;
break;
default:
break;
}

// For a regular offset hh[mm], simply read four digits, with the option of an EOF or non-digit after
Expand Down
9 changes: 9 additions & 0 deletions tests/std/tests/GH_002094_cpp_core_guidelines/test.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@

using namespace std;

#if _HAS_CXX20
void instantiate_chrono_parse_machinery() {
istringstream iss{"10:02:07"};
chrono::seconds s{};
iss >> chrono::parse("%H:%M:%S", s);
assert(s == 36127s);
}
#endif // ^^^ _HAS_CXX20 ^^^

#if _HAS_CXX23
template <class T>
struct WrappedVector : vector<T> {
Expand Down