-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-source-filesystem): Update createRemoteFileNode
args
#35422
Conversation
Hi @Apprentice76 ! Thanks for the contribution 😄 Looks like there's a few
Would you mind fixing these up? |
I'll get to that asap. I updated the function definition, but forgot that there might be packages that might me using the old one. I need to update them as well. |
I've updated the PR, the last failing check(s) are a problem somewhere in the cypress scripts in the e2e_test folders and not related to my code. Kindly review and merge it. |
…tsbyjs#35422) * fixes issue gatsbyjs#35363 and CreateFileNodeFromBufferArgs * modified tests for remote-file-node and file-node-from-buffer * updated function calls in dependencies * removed unused typescript imports Co-authored-by: Ward Peeters <ward@coding-tech.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Description
This is a bugfix for issue #35363 as well as the arguments for 'CreateFileNodeFromBufferArgs'
Documentation
gatsby-source-filesystem docs: https://www.gatsbyjs.com/plugins/gatsby-source-filesystem/#createremotefilenode
Related Issues
Fixes #35363