Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copies from Einstein expression construction #42

Open
dsharlet opened this issue Aug 2, 2020 · 1 comment
Open

Remove copies from Einstein expression construction #42

dsharlet opened this issue Aug 2, 2020 · 1 comment

Comments

@dsharlet
Copy link
Owner

dsharlet commented Aug 2, 2020

Currently, it is not possible to construct an Einstein reduction expression without copying the operands. Most of these copies are small/lightweight (never arrays, only array_refs), but operands that are functions/lambdas may be expensive to copy or not copyable at all.
@dsharlet
Copy link
Owner Author

The fix for this breaks some optimizations related to ein_reduce usage.
@dsharlet dsharlet reopened this Aug 26, 2020
dsharlet added a commit that referenced this issue Aug 26, 2020
@dsharlet
Add copies back to ein_op construction. Unfixes #42, but unbreaks som…
b3fa565 
…e optimizations around ein_reduce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@dsharlet