Improve handling around performance navigation entry #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongrich
force-pushed
the
hongrich/navigation-entry
branch
2 times, most recently
from
e6ab879
to
14dc245
Compare
ajhyndman
reviewed
Jun 6, 2023
hongrich
force-pushed
the
hongrich/navigation-entry
branch
2 times, most recently
from
6da4c18
to
75ee7f5
Compare
Older browsers do not have support for PerformanceNavigationTiming. This changes adds fallback for getting navigation type from the deprecated `window.performance.navigation.type` when PerformanceNavigationTiming is not available. Since `activationStart` is also on PerformanceNavigationTiming, we move this into a helper in the same file as well. Finally, we can override the built-in browser declarations to get better typing for `getEntriesByType`, `activationStart`, and `document.prerendering`. This allows us to remove the override for `@typescript-eslint/ban-ts-comment` eslint rule since the default is pretty reasonable (`ts-expect-error` is allowed with description) https://typescript-eslint.io/rules/ban-ts-comment/
hongrich
force-pushed
the
hongrich/navigation-entry
branch
from
75ee7f5
to
73314f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older browsers do not have support for PerformanceNavigationTiming. This changes adds fallback for getting navigation type from the deprecated
window.performance.navigation.typewhen PerformanceNavigationTiming is not available.Since
activationStartis also on PerformanceNavigationTiming, we move this into a helper in the same file as well.Finally, we can override the built-in browser declarations to get better typing for
getEntriesByType,activationStart, anddocument.prerendering. This allows us to remove the override for@typescript-eslint/ban-ts-commenteslint rule since the default is pretty reasonable (ts-expect-erroris allowed with description) https://typescript-eslint.io/rules/ban-ts-comment/