Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/base: Use std::string directly instead of String typedef #709

Merged
merged 1 commit into from
May 30, 2020
Merged

lib/base: Use std::string directly instead of String typedef #709

merged 1 commit into from
May 30, 2020

Conversation

p12tic
Copy link
Member

@p12tic p12tic commented May 30, 2020 •
edited
Loading

Having a String typedef that points to std::string does not serve any benefit and is just confusing. This PR should not result in any functionality changes, I would expect the produced binary to be exactly the same.
@shymega
Copy link

shymega commented May 30, 2020

Looks fine, merging.
@shymega shymega merged commit 4a2f1a9 into debauchee:master May 30, 2020
@p12tic p12tic deleted the use-std-string-1 branch May 30, 2020 18:22
@ghost ghost mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@p12tic @shymega