feat: Salesforce RR skip based on a user on a lookup field on an account #17526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeauyeung
commented
Nov 7, 2024
| import { RouteActionType } from "../../zod"; | ||
|
|
||
| type FormFieldsQueryBuilderState = { |
There was a problem hiding this comment.
Move types to the types file so they can be used in other components
Comment on lines
424
to
435
| {eventTypeRedirectUrlSelectedOption?.eventTypeAppMetadata && | ||
| "salesforce" in eventTypeRedirectUrlSelectedOption.eventTypeAppMetadata ? ( | ||
| <div className="mt-4 px-2.5"> | ||
| <DynamicAppComponent | ||
| componentMap={routingFormAppComponents} | ||
| slug="salesforce" | ||
| appData={eventTypeRedirectUrlSelectedOption?.eventTypeAppMetadata["salesforce"]} | ||
| route={route} | ||
| setAttributeRoutingConfig={setAttributeRoutingConfig} | ||
| /> | ||
| </div> | ||
| ) : null} |
There was a problem hiding this comment.
TODO: Make this more dynamic and not hard code "salesforce" here
Comment on lines
200
to
212
| const eventTypeAppMetadataParse = EventTypeAppMetadataSchema.safeParse(eventType.metadata?.apps); | ||
| const eventTypeAppMetadata: Record<string, any> = {}; | ||
| if (eventTypeAppMetadataParse.success) { | ||
| const appMetadata = eventTypeAppMetadataParse.data; | ||
|
|
||
| if (appMetadata) { | ||
| for (const appSlug of Object.keys(appMetadata)) { | ||
| if (enabledAppSlugs.includes(appSlug)) { | ||
| eventTypeAppMetadata[appSlug] = appMetadata[appSlug as keyof typeof appMetadata]; | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I know it is in draft but still leaving code feedback.
Let's abstract it out
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Co-authored-by: Alex van Andel <emrysal@users.noreply.github.com>
emrysal
previously approved these changes
Nov 11, 2024
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
…b.com/calcom/cal.com into salesforce-route-to-user-lookup-field
E2E results are ready! |
emrysal
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows users to add a route under a routing form to look up a user under a custom lookup field under a Salesforce account. If that user is a part of the round robin event, then directly book with that user.
https://www.loom.com/share/db809cd26f56481299eac1a4067c885c?sid=940ebec9-021a-4ee4-876d-3bd86486d235
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?