Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Routing form - Add submitted_at and Sort entries with latest on top #17491

Merged
merged 6 commits into from
Nov 11, 2024
Merged

chore: Routing form - Add submitted_at and Sort entries with latest on top #17491

merged 6 commits into from
Nov 11, 2024

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Nov 5, 2024 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
    Screenshot 2024-11-05 190515

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A- I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings
@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.
@dosubot dosubot bot added routing-forms area: routing forms, routing, forms 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Nov 5, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Nov 5, 2024
@graphite-app graphite-app bot requested a review from a team November 5, 2024 13:38
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 5, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

E2E results are ready!
hbjORbj
hbjORbj requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the failing test
anikdhabal
anikdhabal commented Nov 5, 2024
View reviewed changes
packages/app-store/routing-forms/playwright/tests/basic.e2e.ts Outdated
Comment on lines 330 to 335
/* TODO: Find a way to incorporate Routed To, Booked At, Submitted At into the report
expect(responses).toEqual([
["event-routing", "Option-2", "Option-2", "Option-2", "Option-2", "", ""],
["external-redirect", "Option-2", "Option-2", "Option-2", "Option-2", "", ""],
["custom-page", "Option-2", "Option-2", "Option-2", "Option-2", "", ""],
]);
]); */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to handle those three responses in a other way; will make a follow-up PR
Copy link
Contributor

@hbjORbj hbjORbj Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add extra string to the arrays above to get the test passed? In most cases, we shouldn't comment out test cases.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an empty string won't fix it since it's a dynamic value, but I handled it another way
hbjORbj
hbjORbj previously requested changes Nov 6, 2024
View reviewed changes
packages/app-store/routing-forms/playwright/tests/basic.e2e.ts Outdated
Comment on lines 330 to 335
/* TODO: Find a way to incorporate Routed To, Booked At, Submitted At into the report
expect(responses).toEqual([
["event-routing", "Option-2", "Option-2", "Option-2", "Option-2", "", ""],
["external-redirect", "Option-2", "Option-2", "Option-2", "Option-2", "", ""],
["custom-page", "Option-2", "Option-2", "Option-2", "Option-2", "", ""],
]);
]); */
Copy link
Contributor

@hbjORbj hbjORbj Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add extra string to the arrays above to get the test passed? In most cases, we shouldn't comment out test cases.
@hbjORbj
Copy link
Contributor

hbjORbj commented Nov 6, 2024

Left 1 comment.

p.s. Can you please create a branch in the repo, not your fork from next time? e.g., It takes extra effort to fetch, review, push, etc if you open a PR from fork.
@anikdhabal anikdhabal merged commit aaa7510 into calcom:main Nov 11, 2024
32 of 36 checks passed
@anikdhabal anikdhabal deleted the CAL-4642 branch November 11, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e routing-forms area: routing forms, routing, forms
4 participants
@anikdhabal @hbjORbj @Praashh @keithwillcode