wp-now: Remove unnecessary nvm calls

[wojtekn]

What?

In this diff, I propose to remove unnecessary nvm calls from the script that allows running wp-now for development purposes
globally.

Why?

• remove dependency on nvm from the code
• ensure that the script located in bin/ doesn't make changes on the machine when it runs

Related ticket: WordPress/playground-tools#7

How?

I removed the affected code. We still recommend running nvm use in contribution docs, but the user can skip that if wanted to manage node versions in another way.

Testing Instructions

1. Link wp-now in development mode
2. Ensure wp-now still works when used globally from the plugin/theme or other project root

[adamziel]

❤️

[adamziel]

❤️

[danielbachhuber]

Do we need to have a node version check? What happens if your default node version is insufficient?

[wojtekn]

Do we need to have a node version check?

I consider this bin script as a wrapper, a helper that allows running commands similarly to when installed via npm. I wouldn't add any validation logic here, then.

What happens if your default node version is insufficient?

In such a case, I would expect behavior to be the same as for a user who runs npx nx preview wp-now without a wrapper.

[adamziel]

+1 for removing nvm dependency – it prevents people don't use nvm from running this script even if they still have the required Node.js version. @luisherranz expects that to be the case at his WCEU workshop

[wojtekn]

Closing in favor of WordPress/playground-tools#44