Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block API: Set alias_name on block class instances. #6580

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

tjcafferkey
Copy link

@tjcafferkey tjcafferkey commented May 20, 2024

Trac ticket:

Consider the following markup:

<!-- wp:social-links -->
<ul class="wp-block-social-links">
	<!-- wp:social-link {"url":"Tumblr.com","service":"tumblr"} /-->
	<!-- wp:core/social-link/wordpress {"url":"wordpress.com","service":"wordpress"} /-->
</ul>
<!-- /wp:social-links -->

The second social link has an alias core/social-link/wordpress which we need to render correctly on the frontend with the correct CSS class names.

All WP_Block_Type's are registered under their canonical form, meaning aliases are not in the registry. So when we are rendering an alias block type we need to know what the alias is so we can generate the appropriate class names for it, for the above mark up this would be: wp-social-link wp-social-link-wordpress wp-block-social-link.

This PR attempts to solve this by tracking the alias when we look it up in the block registry. When we return the canonical WP_Block_Type it will have an $alias_name property so we know which alias it is representing.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant