Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Book hero and Banner with book description patterns. #299

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 13, 2024

Description

Adding patterns for the "Landing page: Book" page. Adding patterns for the "Hero" and "About the book" sections.

Once this one is merged with the ones from #296, we should be able to create the landing page.

Screenshots

Screen.Recording.2024-09-13.at.18.42.08.mov

Testing Instructions

  1. Create a page.
  2. Add the patterns.
  3. Confirm they're looking like in the designs.
Copy link

github-actions bot commented Sep 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: beafialho <beafialho@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

readme.txt Show resolved Hide resolved
@carolinan
Copy link
Contributor

I just added the one line credit for the book template to the readme.

I have one small feedback, but it is not blocking: If the pre-order text is meant to be a call to action, I think it needs to be more prominent.

@beafialho
Copy link
Contributor

These look great, thank you!

The pre-order text looks as intended.

@juanfra juanfra merged commit 4a28ad0 into trunk Sep 16, 2024
3 checks passed
@juanfra juanfra deleted the add/book-about-and-hero branch September 16, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment