Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pill border color style, add missing pill and miscellaneous adjustments. #281

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Sep 12, 2024

Description

  • Set the border color of the pill style variation to be currentColor to make it work well with the different style variations.
  • "Banner with description and images grid": Added pill style, added margin zero from outer group.
  • "Grid Videos": Added margin zero from outer group. Removed font size from pill styled element as it already comes from the variation.
    "Page coming soon": The border color was removed from the pill style, as the variation now uses currentColor.
    "Photo blog home template": The font size was removed from the pill-styled element as it already comes from the variation.

Screenshots

Screen.Recording.2024-09-12.at.14.38.40.mov

Testing Instructions

Patterns

  1. Create a page and add the following patterns: Banner with description and images grid, Grid videos, page coming soon.
  2. Try different style variations and confirm there's no white space between them, and the pill styles (font size and border) are looking well with the different variations.

Home template.

  1. Open the site editor
  2. Select the Blog home, and apply the "Photo blog home" design. Confirm the pill style font size is looking well.
@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Sep 12, 2024
@juanfra juanfra self-assigned this Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the testing instructions and everything seems to be working well, thank you.

@carolinan carolinan merged commit 4c8629a into trunk Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended.
2 participants