Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin notice for live preview blueprint #604

Conversation

huzaifaalmesbah
Copy link

This pull request introduces an admin notice to the live preview blueprint, designed to remind users that they are viewing a preview and to highlight the Playground feature.

Huzaifa-20240902094322

Testing Instructions:

To test this feature:

  1. Navigate to the Blueprint Builder tool.
  2. Replace the default JSON with the blueprint.json file from this plugin.
  3. Click Run It to see the preview in action.
Copy link

github-actions bot commented Sep 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Co-authored-by: rejaulalomkhan <rejaulalomkhan@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@rejaulalomkhan
Copy link

It's working and very helpful for developers. Thanks for the excellent PR @huzaifaalmesbah

@mukeshpanchal27
Copy link
Member

Why do you think it's necessary to include this additional notice? If it were necessary, the playground would have already done that. Also, I don't think PCP uses the Live Preview feature.

@huzaifaalmesbah
Copy link
Author

Why do you think it's necessary to include this additional notice? If it were necessary, the playground would have already done that. Also, I don't think PCP uses the Live Preview feature.

Thanks for the feedback, @mukeshpanchal27. The notice is meant to improve clarity for users in preview mode, especially those new to the Playground feature. Even if PCP doesn't use Live Preview, this helps maintain consistency. If you think it's not needed, we can avoid it.

@swissspidy
Copy link
Member

I agree with Mukesh here, we don‘t even use Live Preview.

If you think people using Live Preview need a little reminder thaf they are using Playground (why would they though?), I recommend opening a feature request on Playground itself. Adding such a notice to every single plugin is not scalable.

@swissspidy swissspidy closed this Sep 2, 2024
@davidperezgar
Copy link
Member

Yes, It's much better to propose it in Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants