URLInput: Fix incorrect classname for suggestions #66714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7d595d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11664485377
|
Mamaduka
approved these changes
Nov 4, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the invalid 'undefined__suggestions' CSS class that was generated when no
classNameprop was passed to theURLInputcomponent.Why?
We need to check if the class name exists.
Testing Instructions
It's a little difficult to test the
URLInputcomponent directly, so please test it with theImageURLInputUIcomponent, which uses it internally.undefined__suggestionsdoes not exist.Additionally, make the following changes and test that the class name is applied as before.
If you perform the same operation, the suggestion should have the CSS class
test__suggestionsapplied.