Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit test for Tag Cloud Block render function #64773

Closed
wants to merge 4 commits into from
Closed

Added unit test for Tag Cloud Block render function #64773

wants to merge 4 commits into from

Conversation

akasunil
Copy link
Member

What?

Added unit test for Tag Cloud block render function.
@akasunil akasunil added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Block] Tag Cloud Affects the Tag Cloud Block labels Aug 24, 2024
@akasunil akasunil self-assigned this Aug 24, 2024
@Mamaduka
Copy link
Member

I don't think this is necessary.

Why?

  • The render function is simple wrapper around wp_tag_cloud.
  • Not every render function needs unit tests. In my opinion, if the block just passes arguments to a core function and echoes it, unit test coverage isn't needed.
@akasunil
Copy link
Member Author

@Mamaduka Sorry, i didn't see your comment before last commit
@akasunil
Copy link
Member Author

  • Not every render function needs unit tests. In my opinion, if the block just passes arguments to a core function and echoes it, unit test coverage isn't needed.

I see, in that case I'll close this PR then.
@Mamaduka
Copy link
Member

Thanks for the effort, @akasunil!
@akasunil akasunil closed this Aug 24, 2024
@Mamaduka Mamaduka deleted the add/tag-cloud-block-unit-test branch August 24, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tag Cloud Affects the Tag Cloud Block [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
2 participants
@akasunil @Mamaduka