Makes spacing consistent in zoom out vertical toolbar #63994
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitraj2203
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +40 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ebc635a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10111812049
|
richtabor
reviewed
Jul 31, 2024
packages/base-styles/_variables.scss
Outdated
| @@ -86,6 +86,7 @@ $widget-area-width: 700px; | |||
| * Block & Editor UI. | |||
| */ | |||
|
|
|||
| $block-vertical-toolbar-height: $grid-unit-50; | |||
There was a problem hiding this comment.
This seems quite a bit too prescriptive here. I don't think we'd use this anywhere else.
There was a problem hiding this comment.
We tend not to add variables unless we absolutely have to.
As Zoom Out is still behind an experiment I don't think we should add this.
I understand the motivation but it's a premature abstraction in my opinion.
richtabor
reviewed
Jul 31, 2024
| .components-accessible-toolbar, | ||
| .components-toolbar { | ||
| .components-button { | ||
| height: $block-vertical-toolbar-height; |
There was a problem hiding this comment.
Is there a clearer way to do this?
There was a problem hiding this comment.
We can use $grid-unit-50 from here variable instead of creating a new one for 40px. Should I go ahead with that?
There was a problem hiding this comment.
Yes please reuse an existing variable or hard code for the timebeing.
There was a problem hiding this comment.
Removed the variable and used hard code value.
|
Hi @richtabor, Is there something that needs to be done from my side? |
getdave
reviewed
Sep 16, 2024
packages/base-styles/_variables.scss
Outdated
| @@ -86,6 +86,7 @@ $widget-area-width: 700px; | |||
| * Block & Editor UI. | |||
| */ | |||
|
|
|||
| $block-vertical-toolbar-height: $grid-unit-50; | |||
There was a problem hiding this comment.
We tend not to add variables unless we absolutely have to.
As Zoom Out is still behind an experiment I don't think we should add this.
I understand the motivation but it's a premature abstraction in my opinion.
| .components-accessible-toolbar, | ||
| .components-toolbar { | ||
| .components-button { | ||
| height: $block-vertical-toolbar-height; |
There was a problem hiding this comment.
Yes please reuse an existing variable or hard code for the timebeing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #63807
Why?
See this comment
Testing Instructions
Screenshots or screencast