-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - Prevent deleting content when backspacing in the first Paragraph block #62069
Conversation
…raph block at start
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
Flaky tests detected in f0f5eff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9270839912
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @geriux! I tested in an iOS sim and on an Android device. 🚀
…agraph block (WordPress#62069) * Mobile - Prevent deleting content when backspacing in the first Paragraph block at start * Update Changelog Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
…agraph block (WordPress#62069) * Mobile - Prevent deleting content when backspacing in the first Paragraph block at start * Update Changelog Co-authored-by: geriux <geriux@git.wordpress.org> Co-authored-by: twstokes <twstokes@git.wordpress.org>
Related PRs:
What?
This PR brings changes from #56329 to the mobile code.
Why?
Currently, there's an issue when backspacing in the first Paragraph block at the start where the block's content would be removed.
How?
It brings changes from the web's code to solve this issue.
Testing Instructions
Test case 1: Backspacing in the first Paragraph block with content
Test case 2: backspacing in the first Heading block with content
Testing Instructions for Keyboard
N/A
Screenshots or screencast
TestCase1Before.mov
TestCase1After.mov
TestCase2Before.mov
TestCase2After.mov