-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ToggleControl for "Open in new tab" in Settings. #60132
base: trunk
Are you sure you want to change the base?
Conversation
Size Change: +20 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thank you for the PR! In #59994 (comment) I suggesed copying the entire "advanced" section fro the link dialog into the inspector. That means including the chevron to expand/collapse, including the checkbox. Would it be possible to work in that direction? |
@jasmussen Thank you for reviewing! Of course, this toggle button can also be moved to the "Advanced" section. In the I thought it would be a bit confusing to have this feature in the "Advanced" section only in the navigation block. What do you think about this? |
@jasmussen I see. This looks good! |
What?
Add "Open new tab" ToggleControl to the
core/navigation-link
andcore/navigation-submenu
block inspectors.Why?
fix: #59994
How?
ToggleControl was used as in core/post-title.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
2024-03-23.3.33.44.mov