Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate pre-publish and post-publish panels visibility and settings #57469

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

snehapatil2001
Copy link
Contributor

What?

This PR addresses the issue of confusion in the publishing flow where the user interface displays a checkbox in the post-publish panel. The checkbox, when unchecked, disables both the pre and post-publish panels, affecting the user experience.

Why?

Unchecking the only checkbox present disables both pre and post-publish panels, affecting the user's ability to receive suggestions and actions after publishing. The proposed changes aim to improve user understanding and provide a better user experience.

How?

The PR proposes to introduce two different settings to toggle their visibility. This separation allows users to control the display of each panel independently, providing a clearer and more intuitive experience. The changes also ensure that unchecking the checkbox in the post-publish panel only affects the post-publish suggestions, not both panels.

Testing Instructions

  1. Open a post or page in the editor.
  2. Navigate to the publishing flow.
  3. Observe the presence and functionality of the "Always show pre-publish checks" checkbox in both pre and post-publish panels.
  4. Check and uncheck the checkbox to verify its impact on the visibility of pre and post-publish panels.

Testing Instructions for Keyboard

Navigate through the publishing flow using the keyboard and perform the above steps to ensure accessibility and keyboard-only testing.

Screenshots

Screenshots or screencast

Screenshot 2024-01-01 at 7 05 59 PM
Copy link

github-actions bot commented Jan 1, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 1, 2024
Copy link

github-actions bot commented Jan 1, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @snehapatil2001! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@snehapatil2001 snehapatil2001 changed the title feat: Separate pre-publish and post-publish panels visibility and settings #57268 Jan 2, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: snehapatil2001 <snehapatil02@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
1 participant