Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting useCompositeState with Ariakit #56620

Closed
wants to merge 1 commit into from
Closed

Supporting useCompositeState with Ariakit #56620

wants to merge 1 commit into from

Conversation

andrewhayward
Copy link
Contributor

@andrewhayward andrewhayward commented Nov 29, 2023 •
edited
Loading

What?

This PR adds support for useCompositeState using the Ariakit API.

Why?

In order to ease the migration away from reakit, we need to maintain the current public Composite API. reakit exposes a useCompositeState function, which ariakit doesn't directly support, so we need to port this to the new Composite implementation.

How?

  • Add unit tests for current useCompositeState
  • Implement useCompositeState with ariakit

Testing Instructions

  • Ensure unit tests run
@andrewhayward andrewhayward added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Nov 29, 2023
@andrewhayward andrewhayward requested a review from a team November 29, 2023 00:05
@andrewhayward andrewhayward self-assigned this Nov 29, 2023
@ciampo
Copy link
Contributor

ciampo commented Dec 22, 2023

Given the work done in #56645 and #57304, should we close this PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
2 participants
@andrewhayward @ciampo