Enhance: Ensure consistent gradient for background in bottom navigation bar and iPhone home indicator #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on bar and iPhone home indicator
PcolBP
suggested changes
Aug 22, 2024
Comment on lines
+416
to
+417
| return Container( | ||
| decoration: BoxDecoration(gradient: widget.backgroundGradient), |
There was a problem hiding this comment.
Should use DecoratedBox and BoxDecoration inside, its lighter than Container which has a lot of things that are not used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #75. Updated the code to ensure consistent gradient backgrounds for the bottom navigation bar and iPhone home indicator bar. Please review for potential merge.