Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A > Migrations: Add event tracking #96389

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Nov 14, 2024

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1439

Proposed Changes

This PR adds the event tracking to the new migration changes.

Why are these changes being made?

  • To be able to track the events.

Testing Instructions

  • Open the A4A live link > Open the network tab on the browser dev tool > Filter Img and a8c-for-agencies-horizon text.
Screenshot 2024-10-25 at 1 53 16 PM
  • Verify the below tracking events are being captured along with the props mentioned:

Migrations: Overview > Click the Tag sites for commission button

Screenshot 2024-11-14 at 10 32 03 AM
  1. Select all/deselect all
Event: calypso_a8c_migrations_tag_sites_modal_select_all_sites_click
Props: type: select | deselect
  1. Select/deselect one
Event: calypso_a8c_migrations_tag_sites_modal_select_site_click
Props: type: select | deselect
  1. Cancel/Close modal
Event: calypso_a8c_migrations_tag_sites_modal_close
  1. Add Sites
Event: calypso_a8c_migrations_tag_sites_modal_add_sites_click
Props: count

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?
@yashwin yashwin requested a review from a team November 14, 2024 05:06
@yashwin yashwin self-assigned this Nov 14, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 14, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~86 bytes added 📈 [gzipped])

name                         parsed_size           gzip_size
a8c-for-agencies-migrations       +399 B  (+0.0%)      +86 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I have one comment that I think we should include in the track event.

@yashwin yashwin merged commit 39f4e0d into trunk Nov 14, 2024
15 of 17 checks passed
@yashwin yashwin deleted the add/a4a/migrations-event-tracking branch November 14, 2024 05:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants