Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a configuration for the global quick editor experience #450

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Adding a configuration for the global quick editor experience #450

merged 5 commits into from
Oct 3, 2024

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 2, 2024

Closes #

Description

Adding a configuration for the global quick editor experience
So far we are only applying a configuration to override the system color scheme

Testing Steps

  • Run the UIKit demo app
  • Chose the Quick Editor demo screen
  • Select a different color scheme from the current system
  • Open the Quick Editor
    • Check that the Quick Editor respect the selected color scheme.
@etoledom etoledom requested a review from pinarol October 2, 2024 13:05
@etoledom etoledom self-assigned this Oct 2, 2024
@wpmobilebot
Copy link

wpmobilebot commented Oct 2, 2024 •
edited
Loading

Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1369
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commit869b6aa
App Center BuildGravatar SDK Demo - SwiftUI #198
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
@wpmobilebot
Copy link

wpmobilebot commented Oct 2, 2024 •
edited
Loading

Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1369
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit869b6aa
App Center BuildGravatar SDK Demo - UIKit #199
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
@etoledom
Squashed commit of the following:
c39dd7f 
commit 82d1b0f
Author: Pinar Olguc <pinarolguc@gmail.com>
Date:   Thu Oct 3 10:49:34 2024 +0300

    Rename AvatarPickerContentLayoutWithPresentation to AvatarPickerContentLayout
    Rename AvatarPickerContentLayout to AvatarPickerContentLayoutType

commit b066f1e
Author: Pinar Olguc <pinarolguc@gmail.com>
Date:   Thu Oct 3 10:45:40 2024 +0300

    Some renamings

commit c7ea955
Author: Pinar Olguc <pinarolguc@gmail.com>
Date:   Wed Oct 2 18:01:47 2024 +0300

    Add QuickEditorScopeWithConfiguration
pinarol
pinarol approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good 🎉
@etoledom etoledom merged commit b8b33eb into trunk Oct 3, 2024
9 checks passed
@etoledom etoledom deleted the etoledom/color-scheme-setup-uikit-quick-editor branch October 3, 2024 09:30
andrewdmontgomery pushed a commit that referenced this pull request Oct 4, 2024
@etoledom @andrewdmontgomery
Adding a configuration for the global quick editor experience (#450)
5c677cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@etoledom @wpmobilebot @pinarol