Show upload fail error dialog #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinarol
commented
Sep 24, 2024
| var code: String { get } | ||
| /// Error message that comes from the REST API. | ||
| var message: String? { get } | ||
| } |
There was a problem hiding this comment.
I checked the Gravatar backend, the errors have a standard format, a code and a message. The message is optional. So i think we can represent all the business errors with this protocol.
pinarol
requested review from
andrewdmontgomery and
etoledom
and removed request for
andrewdmontgomery
|
 |
App Name |  Gravatar SwiftUI Prototype Build |
| Build Number | 1295 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-swiftui.prototype-build | |
| Commit | 6792f97 | |
| App Center Build | Gravatar SDK Demo - SwiftUI #150 |
|
 |
App Name |  Gravatar UIKit Prototype Build |
| Build Number | 1295 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 6792f97 | |
| App Center Build | Gravatar SDK Demo - UIKit #151 |
etoledom
approved these changes
Sep 25, 2024
Comment on lines
68
to
74
| do { | ||
| let error: ModelError = try data.decode() | ||
| return .invalidHTTPStatusCode(response: response, errorPayload: error) | ||
| } catch { | ||
| // if parsing the error fails then return invalidHTTPStatusCode without the payload. | ||
| return .invalidHTTPStatusCode(response: response) | ||
| } |
There was a problem hiding this comment.
Since we are skipping handling the parsing error, maybe we can avoid using try-catch?
Suggested change
| do { | |
| let error: ModelError = try data.decode() | |
| return .invalidHTTPStatusCode(response: response, errorPayload: error) | |
| } catch { | |
| // if parsing the error fails then return invalidHTTPStatusCode without the payload. | |
| return .invalidHTTPStatusCode(response: response) | |
| } | |
| let error: ModelError? = try? data.decode() | |
| return .invalidHTTPStatusCode(response: response, errorPayload: error) |
Hmm now that you pointed out I feel like it shouldn't. I'll remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373
Description
Adds upload fail dialog.
Some errors are not suitable for retrying, so we don't show the retry option for them. These are the HTTP 400 errors for now. We know from REST API specs that these are validation errors about the image. Maybe we should make this assumption for all 4XX errors. I feel like it is better to show the Retry option in a false positive situation than not show it when it is actually needed.
Others look like this:
Testing Steps
SwiftUI demo app > Avatar Picker View
(It is a bit difficult to generate HTTP 400 errors, i had to comment out some image cropping code to get that not-square error ☝️. )