Add email to the Avatar picker #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
 |
App Name |  Gravatar UIKit Prototype Build |
| Build Number | 1121 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | fa9b7e6 | |
| App Center Build | Gravatar SDK Demo - UIKit #55 |
|
 |
App Name |  Gravatar SwiftUI Prototype Build |
| Build Number | 1121 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-swiftui.prototype-build | |
| Commit | fa9b7e6 | |
| App Center Build | Gravatar SDK Demo - SwiftUI #54 |
pinarol
commented
Aug 21, 2024
| ) | ||
| .padding(.vertical, borderWidth) // to prevent borders from getting clipped |
There was a problem hiding this comment.
not directly related with this PR but I saw that the borders are getting clipped a bit, this fixes it.
pinarol
commented
Aug 21, 2024
| private func header() -> some View { | ||
| VStack(alignment: .leading) { | ||
| Text("Avatars") | ||
| .font(.title2.weight(.bold)) | ||
| Text("Choose or upload your favorite avatar images and connect them to your email address.") | ||
| .font(.subheadline) | ||
| .foregroundColor(Color(UIColor.secondaryLabel)) |
There was a problem hiding this comment.
Not directly related with this PR but this is how it is in the designs and only a 1 line change so I wanted to include here.
etoledom
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346
Description
Testing Steps
Email should be visible at the top.