#55754 closed task (blessed) (fixed)
Bump bundled theme versions for 6.0.0 release
Reported by: | peterwilsoncc | Owned by: | peterwilsoncc |
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-unit-tests dev-reviewed fixed-major |
Focuses: | Cc: |
Description
All bundled themes from 2010 to 2022 will need a version bump for the 6.0 release.
Change History (19)
This ticket was mentioned in PR #2726 on WordPress/wordpress-develop by peterwilsoncc.
2 years ago
#2
- Keywords has-patch added
#3
@
2 years ago
I've linked a pull request to this issue. I still have a couple of themes to test before it's ready.
#4
@
2 years ago
The linked pull request is ready for review.
I've bumped the theme number of all the bundled themes as they've all had some work over the last few months. All of them have had improvements made to the translator comments so it will be good to get those in to the project.
When reviewing the pull request please take a look at the themes directory and let me know if there are any asset version bumps that I have missed.
A few of them get the theme version from wp_get_theme()
so not all themes that have had asset changes need a version bump.
If you're a committer and notice something needs work, feel free to push to my branch. Especially if I am asleep.
This ticket was mentioned in Slack in #core by costdev. View the logs.
2 years ago
mehedifoysal commented on PR #2726:
2 years ago
#6
I checked all of them and look perfect to me
peterwilsoncc commented on PR #2726:
2 years ago
#7
@desrosj @costdev I think I've caught all of the _tested up to_ bumps that are required now. Thanks for catching that.
It looks like several other styles and scripts did not have their versions bumped. I had always just assumed that the theme version was used, but seems that for older default themes, that's not the case.
@peterwilsoncc what do you think about changing all of these date versions to be accurate now? Or, we could just open a follow up ticket.
I reviewed the commits in the `wp-content/themes` directory and manually bumped the assets that had changed.
I think using the theme version is a good idea but let's use a follow up ticket. For themes with build tools it might we worth using wp-scripts to generate the version as it will be more performant. But let's discuss that there.
This ticket was mentioned in PR #2733 on WordPress/wordpress-develop by peterwilsoncc.
2 years ago
#8
- Keywords has-unit-tests added
https://core.trac.wordpress.org/ticket/55754 targeting the 6.0 branch.
#9
@
2 years ago
- Owner set to peterwilsoncc
- Resolution set to fixed
- Status changed from new to closed
In 53416:
#10
@
2 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening because I used the wrong ticket reference in the commit above.
peterwilsoncc commented on PR #2733:
2 years ago
#11
#13
@
2 years ago
- Keywords dev-feedback fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for merging to the 6.0 branch pending another committers sign-off.
SergeyBiryukov commented on PR #2726:
2 years ago
#16
#17
@
2 years ago
While preparing the theme updates for release, I noticed that Twenty Ten did not actually have any changes to the actual source code during the 6.0 cycle.
It looks like adding the Changelog link to the readme.txt
file was missed last time around. This can be updated independent of an actual theme update that is deployed to potentially 1.2 million+ sites (total number of sites with Twenty Ten installed).
Post-release, let's un-bump the version for that theme and get the readme.txt
updated on .org.
https://core.trac.wordpress.org/ticket/55754