Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55103 closed defect (bug) (fixed)

Twenty Twenty-Two: Restore padding for Group blocks with a background color

Reported by: kjellr's profile kjellr Owned by: audrasjb's profile audrasjb
Milestone: 5.9.1 Priority: normal
Severity: normal Version: 6.0
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

The patch that landed in #54944 removed left/right padding that was applied to all group blocks that had a background color. This removal was not necessary to fix the issue posed in the ticket.

Gutenberg provides a random default padding value for Group blocks with a background (reference), and the CSS rule that was removed is meant to sync that up with the default site padding used in the theme.

Removing this value means that content inside of Group blocks (with backgrounds) no longer lines up with other site content. You can see this mismatch if you place two group blocks together, one with a background and one without. Before, the text used to line up on the same left vertical axis, but now it does not:

Before:

https://cldup.com/fUYpxpDlrp.png

Current:

https://cldup.com/QMN9IjKG0M.png

Change History (8)

This ticket was mentioned in PR #2288 on WordPress/wordpress-develop by kjellr.


3 years ago
#1

  • Keywords has-patch added

Restores the padding rule removed in https://github.com/WordPress/wordpress-develop/pull/2281.

---

Site Editor

Before|After

---

https://i0.wp.com/user-images.githubusercontent.com/1202812/152797344-95568916-74a9-48bb-9c90-db4516f8902a.png|https://i0.wp.com/user-images.githubusercontent.com/1202812/152797347-5f7be620-516b-47ed-937d-db5d403eb812.png

Post/Page Editor

Before|After

---

https://i0.wp.com/user-images.githubusercontent.com/1202812/152797323-d84d407c-39f2-47fc-b3ac-b0b30c8dc058.png|https://i0.wp.com/user-images.githubusercontent.com/1202812/152797324-163b6e1e-d837-4c06-82fd-ccb5dacae998.png

Trac ticket: https://core.trac.wordpress.org/ticket/55103

#2 @audrasjb
3 years ago

  • Keywords commit added

Marking for commit.
This will partially revert [52679] (see #54944).
Then, please note that we'll need to backport both changesets at once to branch 5.9.

#3 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 52686:

Twenty Twenty-Two: Restore custom padding for group blocks with a background color.

This change partially reverts [52679] which accidentally removed custom padding for group blocks with a background color.

Follow-up to [52679].

Props kjellr.
Fixes #55103.
See #54944.

#5 @audrasjb
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.
Please note that this will be backported in one commit for both [52686] and [52679].

#6 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52688:

Twenty Twenty-Two: Remove negative side margins on group blocks with a background.

This change fixes an issue where applying a background color to a group block aligned it to the left in the editor.

Props eddystile, audrasjb, webmandesign, sabernhardt, petaryoast, kjellr.
Merges [52679] and [52686] to the 5.9 branch.
Fixes #54944, #55103.

#7 @SergeyBiryukov
3 years ago

  • Summary changed from [Twenty Twenty-Two] Restore padding for Group blocks with a background color to Twenty Twenty-Two: Restore padding for Group blocks with a background color

#8 @SergeyBiryukov
3 years ago

In 52709:

Twenty Twenty-Two: Update mergeinfo after [52688].

See #54944, #55103.

Note: See TracTickets for help on using tickets.