Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54755 closed defect (bug) (fixed)

String change for 5.9 about page

Reported by: hlashbrooke's profile hlashbrooke Owned by: audrasjb's profile audrasjb
Milestone: 5.9 Priority: normal
Severity: critical Version: 5.9
Component: Help/About Keywords: has-patch i18n-change commit fixed-major dev-reviewed
Focuses: Cc:

Description

We need to make a change to the Learn WordPress call out on the 5.9 about page.

It currently says:

Want to dive into 5.9 but don’t know where to start? Visit learn.wordpress.org/workshops for short how-to video tutorials and expanding resources on new features in WordPress 5.9.

The workshops page doesn't specifically show 5.9 content at this stage (and likely won't until much later), so it needs to be changed to this:

Want to dive into 5.9 but don’t know where to start? Visit learn.wordpress.org for expanding resources on new features in WordPress 5.9.

learn.wordpress.org would need to be linked to ​https://learn.wordpress.org/ of course.

I know it's late, but this is important to prevent a link to something that doesn't show what people will expect to find. We have also made sure to retain the existing string as much as possible.

Change History (12)

This ticket was mentioned in ​PR #2117 on ​WordPress/wordpress-develop by ​audrasjb.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/54755

#2 @audrasjb
3 years ago

  • Milestone changed from Awaiting Review to 5.9

#3 @audrasjb
3 years ago

  • Keywords i18n-change added

#4 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#5 @audrasjb
3 years ago

  • Component changed from General to Help/About

#6 @davidbaumwald
3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

PR looks good. Marking dev-reviewed.

#7 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52453:

Help/About: Change the Learn WP link in the about page.

The workshops page doesn't specifically show 5.9 content at this stage (and likely won't until much later), so it needs to be changed to learn.wordpress.org homepage.

Props hlashbrooke, audrasjb, davidbaumwald.
Fixes #54755.

#8 @audrasjb
3 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport to branch 5.9.

#9 @audrasjb
3 years ago

  • Keywords dev-feedback added; dev-reviewed removed

Marking as dev-feedback for double committer sign off before backporting this to 5.9.

We already have one, @davidbaumwald. We need a second committer sign off.

#11 @hellofromTonya
3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

Backport for RC needs 1 core committer to mark for dev-reviewed and the 2nd core committer is the person committing it. (The handbook is confusing on this point.) But I think @audrasjb, if you commit, then you serve as the dual-reviewer.

#12 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52542:

Help/About: Change the Learn WP link in the about page.

The workshops page doesn't specifically show 5.9 content at this stage (and likely won't until much later), so it needs to be changed to learn.wordpress.org homepage.

Props hlashbrooke, audrasjb, davidbaumwald.
Merges [52453] to the 5.9 branch.
Fixes #54755.

Note: See TracTickets for help on using tickets.