Opened 3 years ago
Closed 3 years ago
#54745 closed defect (bug) (fixed)
REST API: Wrong punctuation in `$schema['properties']['object']` description
Reported by: | La Geek | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Text Changes | Keywords: | i18n-change has-patch dev-reviewed commit fixed-major |
Focuses: | Cc: |
Description
The type of object originally represented, such as "category," "post", or "attachment."
should be
The type of object originally represented, such as "category", "post", or "attachment".
Attachments (2)
Change History (13)
#1
@
3 years ago
- Keywords i18n-change added
- Owner set to audrasjb
- Status changed from new to assigned
- Summary changed from Wrong punctuation to REST API: Wrong punctuation in `$schema['properties']['object']` description
#3
@
3 years ago
- Keywords dev-feedback has-patch added
Reminder: as we entered release candidate commit will require double-signoff using the dev-feedback and dev-reviewed Trac keywords.
#5
@
3 years ago
I'd vote for fixing this before 5.9 is released, despite the string freeze.
I believe it's important that core, as much as possible, show the right way to handle various strings.
(And this is a tricky one, since English actually does place commas, etc before the closing quotation mark, but here is not a quotation, but a string delimiter.
#6
@
3 years ago
- Keywords dev-reviewed commit added; dev-feedback removed
Hmm, the context of these quotations is not to quote someone but rather to denote a specific thing such as a category or post. Quoting someone in English would place the punctation inside of the closing quotation mark as @tobifjellner notes.
Given that the quotation marks are different here, I think 54745.2.diff is the more correct version.
Hello, thank you for spotting this!
Moving for 5.9 consideration.
We're in hard string freeze though, so we'll see if it's better to fix this in 5.9 or 5.9.1.