#51815 closed defect (bug) (fixed)
Make the URL translatable in wp-admin/includes/class-wp-site-health.php
Reported by: | tai | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Site Health | Keywords: | has-patch commit dev-reviewed i18n-change |
Focuses: | Cc: |
Description
Found the URL should be translatable in wp-admin/includes/class-wp-site-health.php
https://build.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-site-health.php#L2128
'https://developer.wordpress.org/rest-api/frequently-asked-questions/#why-is-authentication-not-working',
Attachments (1)
Change History (10)
This ticket was mentioned in Slack in #core-site-health by tobifjellner. View the logs.
4 years ago
#3
@
4 years ago
- Component changed from I18N to Site Health
- Keywords needs-refresh added
- Type changed from enhancement to defect (bug)
- Version changed from trunk to 5.5
#4
@
4 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 49650:
#5
@
4 years ago
- Keywords commit dev-feedback added; needs-refresh removed
- Resolution fixed deleted
- Status changed from closed to reopened
- Version changed from 5.5 to trunk
Reopening for backporting to the 5.6 branch after a second committer's review.
All the other DevHub reference links in wp-admin
are translatable at a glance, so this brings some consistency.
This is a new URL added in [49334], changing the version accordingly.
Haven't refreshed the tab before committing, and didn't see the suggestion about the numbered placeholders :) We do indeed prefer numbered placeholders in translatable strings if there is more than one placeholder, per #19090 and some other tickets. If the string with multiple placeholders is not translatable (as is the case here), I don't have strong feelings either way.
Looks like a good enhancement. Maybe also worth to use numbered placeholders: %1$s, %2$s, etc, for better clarity.
Those strings appeared in WordPress 5.5.