Twenty Twenty: Author archive with no posts

[SGr33n]

Hi,
The TwentyTwenty behavior for authors archive pages, where the author didn't publish any post, has probably a bug.
Where oldest themes, like twentyninteen had "nothing found" the new twentytwenty have a blank page with a title "Author:".

Thanks!

[SGr33n]

TwentyNineteen

[SGr33n]

TwentyTwenty

[williampatton]

Hey @SGr33n, nice catch here - thank you for opening a ticket. I'll pick this one up and sort it this weekend. Should be a fairly easy one to solve I think :)

[SGr33n]

Yes, if you have time, othwerwise I could address this, no problem :)

[williampatton]

If you are able to make a patch for it please do go ahead. That would be super helpful :)

I can't get time for it till the weekend but I am certain it's a relatively simple fix so if you wanted to take care of it before then feel free.

I'll milestone it for 5.5 as I am pretty sure it can be shipped then.

[SGr33n]

Good! so hear you later.

[rebasaurus]

Patch to fix 50421.

[SGr33n]

My patch, I replicated the twentynineteen behavior (search form below).
I also corrected the stable version in the readme.txt, I suppose it will became 1.5.

[williampatton]

wow 2 patches to pick from and both have solutions. That almost never happens! Will look these over as soon as I am able. Maybe @ianbelanger can look them over too since he will be the one we need to ask to do the commiting :)

[priyomukul]

Seems like there is no template-parts for nothings found like we have in Twenty Nineteen theme ( template-parts/content/content-none.php )

[Asif2BD]

@williampatton @ianbelanger now you get 3! Welcome to @priyomukul on his first patch!

[virginienacci]

Before patch bug on title

[virginienacci]

After patch : Nothing Found is displayed

[virginienacci]

Hi,

I tested the patch 50421.diff​ added by @rebasaurus

It replaces the title correctly.

Have a nice day

Virginie

[audrasjb]

I tested all proposed changes as well, and 50421.diff is the only one to fix the issue in my testing. I think it would be a nice to have for 5.5 as the issue is easy to reproduce.

[williampatton]

Since @SGr33n was first to provide a patch here and it is the simplest of the options I think we should go with that one. It's also the only one that was able to be applied when @audrasjb tested.

I tested myself too and verified it works. I do think the other patches can be added though at a later point as enhancements to the behavior.

This first patch is ready to commit @ianbelanger :)

[williampatton]

Just updating here that I tagged the wrong person previous message. The original patch is provided by @rebasaurus and it is the one we will go for here.

Other patches can be sent through with additional tickets though as they seem like good enhancements. For this one I chose to go with the simplest patch and that is the first one.

[whyisjake]

In 48355:

Bundled theme: Ensure appropriate title for author archives for that don't have posts.

Rather then displaying Author: , show Nothing Found.

Fixes #50421.

Props SGr33n, williampatton, ianbelanger, rebasaurus, priyomukul, virginienacci, audrasjb.