#37008 closed enhancement (fixed)
Unit test for the remove_query_arg method
Reported by: | borgesbruno | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Continuing my noble purpose to increase the code coverage =D, I wrote some tests for the remove_query_arg
, this one removes query from the current URI using all query keys (Array or string) specified on the first param.
Attachments (1)
Change History (5)
Note: See
TracTickets for help on using
tickets.
Thanks, @borgesbruno! It is indeed a noble purpose :)
A couple of minor notes about formatting and convention:
remove_query_arg()
can be more succinctly tested by passing in an explicit URL. It's worthwhile to test that the current URL is used as a fallback, but I think it should happen in a separate test@ticket
annotation if the tests being introduced don't demonstrate a bug or a bugfix