Screen Options: change the "editor-expand" checkbox description to include DFW

[azaozz]

This checkbox controls both editor-expand and DFW v2. When it is unchecked the "Fullscreen" button in disabled and greyed out.

[azaozz]

Perhaps:

Expand the editor to match the window height and enable use of Distraction Free Writing.

Or maybe:

Focus on writing: auto resize the editor and enable use of Distraction Free Writing mode.

[kpdesign]

"Expand the editor to match the window height, and enable distraction-free writing." is concise, and will allow us to build on the existing string.

30557.diff​ contains the above text change.

[johnbillion]

Can the DFW button be hidden rather than just greyed out when editor expand is disabled?

[johnbillion]

In fact, why is there a screen option for editor expand? It seems like something that should always just be on.

What's the use case for disabling it?

[kpdesign]

Replying to johnbillion:

In fact, why is there a screen option for editor expand? It seems like something that should always just be on.

What's the use case for disabling it?

Because there are users who don't care for it, and the checkbox was added in Screen Options to allow them to turn it off (see r29336 and r29588).

[GregLone]

Replying to johnbillion:

In fact, why is there a screen option for editor expand? It seems like something that should always just be on.

What's the use case for disabling it?

Simple: a veeeeeeeeery long post with meta boxes under the editor (scroll, scroll, scroll, scroll...).
I personnally hate this feature :/

[azaozz]

Replying to johnbillion:

Can the DFW button be hidden rather than just greyed out when editor expand is disabled?

Sure, it would only take a little of CSS. I remember this being discussed somewhere, don't seem to be able to find it in ​https://wordpress.slack.com/messages/feature-focus/. Think it was not hidden to make it more discoverable (the old DFW button was visible at all times). However the problem of "how to enable DFW when editor-scrolling is off" seems worse.

[azaozz]

Related: #30568.

[kpdesign]

With #30568 in, do we still want to make this change to the Screen Options text?

[azaozz]

Replying to kpdesign:

Sure, will make it better/accurate.

[azaozz]

In [30718]:

Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557.

[helen]

I am not loving this sentence at all, and I think it's confusing to those who might wonder why the two things are coupled together. Is there something we can come up with to refer to it all together that doesn't feel like a code name? "Enable the adaptive editor", maybe?

[azaozz]

In 30734:

Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557.

[xibe]

Folks, please see #30657 for another string that was impacted by this string change.