Opened 19 years ago
Closed 17 years ago
#1971 closed defect (bug) (wontfix)
Trackback "response" not used consistently
Reported by: | NathanWong | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 1.6 |
Component: | General | Keywords: | |
Focuses: | Cc: |
Description
As you're probably aware, wp_trackback.php has a function called trackback_response() that sends an error (or says "no errors found" at the end). This works great, except for one problem. When there's an error from within wp_new_comment (for example "Sorry, you can only post a new comment once every 15 seconds. Slow down cowboy." and "Duplicate comment detected; it looks as though you've already said that!"), it shows the textual error, and doesn't respond any XML content (not to mention forcing the page to be non-XML compliant).
While I realize this is a minor detail, and it would take a much more advanced error system to overcome, I thought I'd report it anyway.
Attachments (1)
Change History (17)
#5
@
18 years ago
- Milestone set to 2.2
- Priority changed from lowest to normal
- Resolution wontfix deleted
- Severity changed from trivial to normal
- Status changed from closed to reopened
This can mess up trackbacks completely, so re-opening it. Not life-threatening, but not that insignificant.
Options are to add a "silent mode" to wp_insert_comment() or change wp_insert_comment() to return a WP_Error instead, and let the caller decide what to do with the result.
#9
@
18 years ago
#3775 has a similar problem, with wp_die() die()ing with values that don't work with AJAX responses.
No one bit in a year. Closing for now.