Make WordPress Core

Opened 19 years ago

Closed 17 years ago

#1971 closed defect (bug) (wontfix)

Trackback "response" not used consistently

Reported by: nathanwong's profile NathanWong Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: General Keywords:
Focuses: Cc:

Description

As you're probably aware, wp_trackback.php has a function called trackback_response() that sends an error (or says "no errors found" at the end). This works great, except for one problem. When there's an error from within wp_new_comment (for example "Sorry, you can only post a new comment once every 15 seconds. Slow down cowboy." and "Duplicate comment detected; it looks as though you've already said that!"), it shows the textual error, and doesn't respond any XML content (not to mention forcing the page to be non-XML compliant).

While I realize this is a minor detail, and it would take a much more advanced error system to overcome, I thought I'd report it anyway.

Attachments (1)

1971.diff (669 bytes) - added by rob1n 18 years ago.

Download all attachments as: .zip

Change History (17)

#1 @NathanWong
19 years ago

  • Component changed from Administration to General

#2 @matt
19 years ago

  • Milestone changed from 2.0 to 2.1

#3 @matt
18 years ago

  • Milestone changed from 2.1 to 2.2

#4 @foolswisdom
18 years ago

  • Milestone 2.2 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

No one bit in a year. Closing for now.

#5 @rob1n
18 years ago

  • Milestone set to 2.2
  • Priority changed from lowest to normal
  • Resolution wontfix deleted
  • Severity changed from trivial to normal
  • Status changed from closed to reopened

This can mess up trackbacks completely, so re-opening it. Not life-threatening, but not that insignificant.

Options are to add a "silent mode" to wp_insert_comment() or change wp_insert_comment() to return a WP_Error instead, and let the caller decide what to do with the result.

#6 @rob1n
18 years ago

  • Owner changed from anonymous to rob1n
  • Status changed from reopened to new

#7 @rob1n
18 years ago

  • Status changed from new to assigned

#8 @rob1n
18 years ago

  • Keywords dev-feedback 2nd-opinion added

#9 @rob1n
18 years ago

#3775 has a similar problem, with wp_die() die()ing with values that don't work with AJAX responses.

@rob1n
18 years ago

#10 @rob1n
18 years ago

  • Keywords has-patch added; dev-feedback 2nd-opinion removed

With a wee bit 'o' output buffering, I think the problem's licked.

#11 @rob1n
18 years ago

  • Keywords has-patch removed

Never mind, patch doesn't fix.

#12 @foolswisdom
18 years ago

  • Milestone changed from 2.2 to 2.3

#13 @rob1n
18 years ago

  • Status changed from assigned to new

#14 @ryan
17 years ago

  • Milestone changed from 2.3 to 2.4

#15 @rob1n
17 years ago

  • Owner rob1n deleted

#16 @Nazgul
17 years ago

  • Milestone 2.5 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Reclosing as wontfix as this ticket has once again gone to sleep.

Feel free to re-open if you have additional patches/information/suggestions/...

Note: See TracTickets for help on using tickets.