Add a few more hide-if-no-js classes

[johnbillion]

There are a few elements to which we could add the hide-if-no-js class, as their functionality or setting relies on JavaScript being available.

[johnbillion]

Patch. Hides the Press This link and two user settings which need JavaScript to function.

[nacin]

Does Press This actually need JS? Many probably selectively disable JavaScript at the domain level, rather than the browser level. I'm thinking that a browser bookmarklet may still work in the case of NoScript/AdBlock, etc.

[azaozz]

The current implementation of Press This needs JS enabled for both domains, the WP install and the visited site. However if NoScript is used it's trivial to enable JS temporarily and use Press This.

[johnbillion]

Attached patch adds 'hide-if-no-js' class to the "Edit Image" button when viewing a media item, as image editing required JS.

[SergeyBiryukov]

Related: #19606, #19661

[DrewAPicture]

Choose from Media Library links

[DrewAPicture]

18900-header-bg.diff​ hides the 'Choose Image' button (from Media Library) on Custom Header & Custom Background pages. I left the direction label and added a "You need javascript to do this" message: ​http://cl.ly/image/3A3l2H420g40

[DrewAPicture]

Simplifies the UI, no empty space if no-js

[DrewAPicture]

18900-header-bg.2.diff​ Simplifies the UI, removes the entire <p> block if no-js and displays message instead: ​http://cl.ly/image/2a1C1u0L1J2A

[DrewAPicture]

Only introduce one new string, not two.

[DrewAPicture]

Combines with 18900.2.patch

[SergeyBiryukov]

#24321 was marked as a duplicate.

[Mte90]

patch refreshed

[Mte90]

Refreshed the patch with the latest 4.6 branch.

[chriscct7]

In 18900.3.patch src/wp-admin/includes/media.php should use double quotes to enclose the classes for consistency

[Mte90]

only double quotes for classes

[Mte90]

Fixed :-)

[ocean90]

@Mte90, @chriscct7: src/wp-admin/includes/media.php requires single quotes because the string is wrapped with double quotes.

18900.4.patch​ adds the classes only to deprecated functionality. themes.php?page=custom-background and themes.php?page=custom-header are only accessible when JS is disabled. We could add the class to the buttons but I don't think that the extra message is necessary.

The class inget_media_item() seems to be useless because the whole media stuff requires JS to work properly. You can test this by opening wp-admin/media-upload.php?type=image&tab=type in a new tab. Append &post_id=$post_id to get the media of a specific post.

[ocean90]

Going to close this as a wontfix. If there is a place which really requires a hide-if-no-js class a new ticket should be opened.