#16047 closed enhancement (fixed)
Post formats should have its own column on edit.php, hidden by default
Reported by: | nacin | Owned by: | markjaquith |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Post Formats | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
Post Formats currently are displayed in the title row.
Ideally, they should be their own column. This column should be hidden by default. (Doing this, I've found, is not particularly easy given how we currently handle columns.)
NB: We should consider requesting an icon set from Ben as well, now that we're out of v1 for the feature.
I'm committing a quick fix to clean up how they are currently displayed in the title row.
Attachments (14)
Change History (48)
#2
@
14 years ago
For the 3.1 patch, which is fine to Jane: http://cl.ly/212g3O0n172M2x3f3x00
Currently: http://cl.ly/1j0A2O3F3L3n1e3S1V12
#4
@
14 years ago
- Keywords has-patch needs-testing added; needs-patch removed
In order to hide post format column by default, I have to add another user option. Other than that, the patch is pretty straightforward.
On another note, should we add a filter hook somewhere in get_hidden_columns()
? That would make hiding Post format column a little bit cleaner.
#5
@
14 years ago
- Keywords needs-patch added; has-patch needs-testing removed
Ideally, it should be possible for any plugin to hide a column by default. We don't want a new user option here, especially not specific to post formats.
Meta boxes can be hidden by default. The same approach, ideally, should be taken.
#6
@
14 years ago
- Keywords has-patch needs-testing added; needs-patch removed
Ideally, this should be ideal :)
#16
@
12 years ago
I think we decided to allow post formats regardless of current_theme_supports( 'post-formats' )
, so we should probably remove those checks
#18
in reply to:
↑ 17
@
12 years ago
Replying to wonderboymusic:
Yep, removed in latest attached patch
Thanks. I think we should take it one step further and make the column visible by default. We're trying to bring formats into focus, so let's do it all the way. Done in 16047.6.diff
#20
@
12 years ago
Guess I should have refreshed the ticket first. Mark beat me to it - .7 and .8 are exactly the same.
#21
@
12 years ago
- Owner set to markjaquith
- Resolution set to fixed
- Status changed from new to closed
In 23392:
#22
follow-up:
↓ 23
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Compelled to re-open this for a few reasons:
- This is UI cruft if a user's theme doesn't support post formats, and never has. I disagree with "I think we should take it one step further and make the column visible by default. We're trying to bring formats into focus, so let's do it all the way." As discussed in IRC last week, there are ways to make post formats visible without shoving them into the faces of all WordPress users, including those who have zero need for them. We discussed making it so tabs don't show up by default in some circumstances. The same should occur for this.
- In lieu of a column, distinct images representing each format is likely more effective than text labels, given this is not super-important information and cannot (or should not be able to be) changed via quick edit.
- Is showing the word "Standard" over and over necessary? What about just a simple — dash? We now do that for no tags and no categories, rather than showing "No tags" and "Uncategorized" every time. It's cleaner and seems to be working.
- If we do have text, it should be clickable to filter down posts of that format. ?post_format= does work in the admin, we made sure of that back in 3.1 if I recall correctly.
#23
in reply to:
↑ 22
@
12 years ago
Replying to nacin:
Compelled to re-open this for a few reasons:
- This is UI cruft if a user's theme doesn't support post formats, and never has. I disagree with "I think we should take it one step further and make the column visible by default. We're trying to bring formats into focus, so let's do it all the way." As discussed in IRC last week, there are ways to make post formats visible without shoving them into the faces of all WordPress users, including those who have zero need for them. We discussed making it so tabs don't show up by default in some circumstances. The same should occur for this.
I could get behind not showing the column by default.
- In lieu of a column, distinct images representing each format is likely more effective than text labels, given this is not super-important information and cannot (or should not be able to be) changed via quick edit.
Perhaps related? #23333 (New icons)
- Is showing the word "Standard" over and over necessary? What about just a simple — dash? We now do that for no tags and no categories, rather than showing "No tags" and "Uncategorized" every time. It's cleaner and seems to be working.
I think we should just not show anything if there's no post format set. The 'standard' keyword is used a lot in themes when doing a content loop but it's odd outside of that context.
- If we do have text, it should be clickable to filter down posts of that format. ?post_format= does work in the admin, we made sure of that back in 3.1 if I recall correctly.
I think #15323 covers this (Filter by post format in wp-admin/edit)
#24
@
12 years ago
.8
links it (for non-standard ones, as standard links don't work), uses a dash for standard.
Agree with point 2 in nacin's comment, but we don't have those images yet.
#25
@
12 years ago
Replying to nacin:
- In lieu of a column, distinct images representing each format is likely more effective than text labels, given this is not super-important information and cannot (or should not be able to be) changed via quick edit.
You can change it via quick edit. Should probably remove that: #23426. Otherwise, I am fine with an icon, probably in the title column; we just don't have icons yet.
- Is showing the word "Standard" over and over necessary? What about just a simple — dash? We now do that for no tags and no categories, rather than showing "No tags" and "Uncategorized" every time. It's cleaner and seems to be working.
I said yes because of having the column on by default. If not (not on by default or not a column/just icons), then no.
#26
@
12 years ago
I agree that icons would be better. When the icons are done let's ditch the column and add them to the title column.
#28
@
12 years ago
As the posts table is "fixed" adding another column without setting width
doesn't scale well on narrower screens. The above patch fixes that and tweaks the other columns widths.
#31
@
12 years ago
16047.10.diff, needs post-formats-icons.zip. Screenshot below; tested 2x icon placement in iOS simulator, wouldn't mind somebody looking on an actual HiDPI display.
Quick fix for 3.1.