Code smell: Difference between revisions

It has been suggested that this article be merged with Refactoring. (Discuss) Proposed since February 2012.

In computer programming, code smell is any symptom in the source code of a program that possibly indicates a deeper problem. Code smells are usually not bugs -- they are not technically incorrect and don't currently prevent the program from functioning. Instead, they indicate weaknesses in design that may be slowing down development or increasing the risk of bugs or failures in the future.

Often the deeper problem hinted by a code smell can be uncovered when the code is subjected to a short feedback cycle where it is refactored in small, controlled steps, and the resulting design is examined to see if there are any further code smells that indicate the need of more refactoring. From the point of view of a programmer charged with performing refactoring, code smells are heuristics to indicate when to refactor, and what specific refactoring techniques to use. Thus, a code smell is a driver for refactoring.

The term appears to have been coined by Kent Beck on WardsWiki in the late 1990s. Usage of the term increased after it was featured in Refactoring: Improving the Design of Existing Code.^[1] Code Smell is also a term used by agile programmers. ^[2]

Determining what is and is not a code smell is often a subjective judgment, and will often vary by language, developer and development methodology. There are tools, such as Checkstyle, PMD and FindBugs for Java, to automatically check for certain kinds of code smells.

• Duplicated code: identical or very similar code exists in more than one location.
• Long method: a method, function, or procedure that has grown too large.
• Large class: a class that has grown too large. See God object.
• Too many parameters: a long list of parameters in a procedure or function make readability and code quality worse.
• Feature envy: a class that uses methods of another class excessively.
• Inappropriate intimacy: a class that has dependencies on implementation details of another class.
• Refused bequest: a class that overrides a method of a base class in such a way that the contract of the base class is not honored by the derived class. See Liskov substitution principle.
• Lazy class / Freeloader: a class that does too little.
• Contrived complexity: forced usage of overly complicated design patterns where simpler design would suffice.
• Excessively long identifiers: in particular, the use of naming conventions to provide disambiguation that should be implicit in the software architecture.
• Excessively short identifiers: the name of a variable should reflect its function unless it's obvious.
• Excessive use of literals: these should be coded as named constants, to improve readability and to avoid programming errors. Additionally, literals can and should be externalized into resource files/scripts where possible, to facilitate localization of software if it is intended to be deployed in different regions.
• Ubercallback: a callback that is trying to do everything

• Anti-pattern
• Category Programming principles
• Category Programming rules of thumb
• List of tools for static code analysis

• CodeSmell at c2.com
• Taxonomy of code smells
• Overview of many code smells