Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scholar button #143

Open
vict0rsch opened this issue Feb 20, 2023 · 8 comments
Open

Scholar button #143

vict0rsch opened this issue Feb 20, 2023 · 8 comments
Labels
enhancement 🖌 New feature or request help wanted 👋 Extra attention is needed low priority 🐢

Comments

@vict0rsch
Copy link
Owner

Would be nice to have a button when browsing GS to add to PM

@vict0rsch vict0rsch added enhancement 🖌 New feature or request help wanted 👋 Extra attention is needed low priority 🐢 labels Feb 20, 2023
@julien-blanchon
Copy link
Collaborator

I could do this in the following month

@vict0rsch
Copy link
Owner Author

Let me know if you're lost in the code base, it's a bit messy, I need to clean up and document...

@vict0rsch
Copy link
Owner Author

Hey @julien-blanchon no pressure, just to know whether this is still in your plans? (no rush for the feature though, I just thought of it as I opened #178)

@julien-blanchon
Copy link
Collaborator

julien-blanchon commented Aug 27, 2023

Heyyy, sorry for the delay. I'm pretty busy and I'm letting that for later.
I did work a little bit on this at the time of my post, but it's clearly not done.

As I was in the TGV OuiGo without internet I did not push my work at the time 😂, you can now find this on the 143 feature branch on my fork repo (https://github.com/julien-blanchon/PaperMemory/tree/143_scholar_button).

Screenshot 2023-08-28 at 00 50 54

Next time in the OuiGo may be enouth to complete this ;)

@julien-blanchon
Copy link
Collaborator

Btw don't bother about the styling of the button It's clearly not done yet.
But if you have some idea/image/code snippet to share, please do.

Otherwise we would discuss this later

@vict0rsch
Copy link
Owner Author

No rush @julien-blanchon it's just to know.
In terms of idea/image/code I can help if you want but in general FYI I use Tabler Icons, typically here -> https://github.com/vict0rsch/PaperMemory/blob/master/src/shared/js/utils/functions.js#L318

And I use Arxiv's main colour: #b31b1b

If you want to contribute directly, I can make you a collaborator to the repo so you don't have to fork?

@julien-blanchon
Copy link
Collaborator

Sound great, you can add me as collaborator

@vict0rsch
Copy link
Owner Author

Invitation sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🖌 New feature or request help wanted 👋 Extra attention is needed low priority 🐢
2 participants