-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support time-bounded popularity #359
Comments
Hi - looking for some fun side things to hack on during my spare time and got happily surprised to see lkpy having a spike of activity! Are these tickets open for contributors and if so is this a good starter ticket? Thanks! |
Looked at this a little bit - I assume this should be now done with the new |
Hi @ZiyaoWei — very glad you're interested in helping! You're right there's a lot of activity, and it makes things a bit of a moving target (and having built the pipeline and dataset abstractions, the next big lift there is to overhaul all of the model implementations to use them — so I think having it be a separate class from If you wanted to work on a PR for the current APIs, you'd be welcome to; if you want to wait a couple weeks or so for the model API overhaul to land and do itagains the new code, that would remove the need to learn how to code for the current API. |
Wow, thanks for the thoughtful and detailed response! I am traveling too this week and definitely can wait a few days, but overall would be happy to contribute :-) Just curious about the API refactoring - is it happening in a branch I can check out? If not I can wait. |
Definitely still interested but it seems the refactor might have stalled - anything else I can hack on in the meantime? |
@ZiyaoWei The most important pieces for this bit are actually there now — it isn't hooked into the evaluator yet, but the new pipeline component |
Just realized the issue description mentions time-weighted popularity - not sure what's the canonical way to compute it? (And if you think it should be punted feel free to let me know if there are other things that are open to contibutions!) |
Yeah, let's make that a separate change (and probably a separate component). There are a few models in the literature but nothing standard. |
Right now,
Popular
is based on overall popularity.We should add support for time-bounded popularity: most popular items in the last N days.
Time-weighted popularity could also be interesting.
The text was updated successfully, but these errors were encountered: