Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: When the endpoint is returning a hash, the second request returns null #5

Closed
jcagarcia opened this issue Nov 6, 2023 · 0 comments
Closed

bug: When the endpoint is returning a hash, the second request returns null #5

jcagarcia opened this issue Nov 6, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
0.1.2

Comments

@jcagarcia
Copy link
Owner

Seems that we have an invalid check in he code that is making that the response when the endpoint returns a hash, is being stored in a wrong way. Due to that, when requesting the same endpoint with the same idempotency key, the result of the operation is returning null, as it was cached but with invalid format.
@jcagarcia jcagarcia added the bug Something isn't working label Nov 6, 2023
@jcagarcia jcagarcia added this to the 0.1.2 milestone Nov 6, 2023
jcagarcia added a commit that referenced this issue Nov 6, 2023
@jcagarcia
fix(#5): Prevent to change the response if the endpoint returns a hash
de44586
jcagarcia added a commit that referenced this issue Nov 6, 2023
@jcagarcia
Merge pull request #6 from jcagarcia/hash-error
90091be 
fix(#5): Prevent to change the response if the endpoint returns a hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant
@jcagarcia