This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Spinners seem to not work most of the time and it's hard to catch and fix, so I'm doing it all at once.
How
Disable spinners in EXPO_DEBUG mode, this just tends to work better because the spinners don't disappear, giving a slightly better debug log.
Fix spinner respect logic for progress bars and spinners -- the spinner/bar is pushed down while the log is printed above it, the default behavior is to copy the bar or spinner (undesired).
Make more spinners use the respect logic by default.
Fix unmounting logic.
When we resume a spinner, it should continue animating and not freeze when moved down.
When we respect spinners we shouldn't accidentally unpause them.
Fixed loader/spinner when downloading and installing the Expo Go apps
Removed an extra usage of expo/simple-spinner
Fixed server error / spinner style after cancelling during an adb process
Test Plan
I tried rolling some unit tests, but we disable the logs in a few places, so I found it easiest to just write some logging logic in
expo start
:And for progress bars: