This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
code signing xcode projects automatically in development #3317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Right now, if you build a new iOS app onto a physical iOS device (not simulator), the CLI will throw an error regarding code signing. The only way to resolve this error is to open Xcode and configure code signing manually, at this point most users will continue to use Xcode for their app development. This PR introduces a solution to this problem which creates a seamless experience for most users so they never need to open Xcode.
When using the new iOS build command
expo run:ios
(still in alpha), we'll automatically configure code signing directly from the CLI. This feature is unique to expo-cli and afaik never been done before in the React ecosystem so it should be a pretty nice new feature for users developing native apps locally, outside of the Expo client app.How
Test Plan
npx create-react-native-app -t blank
-- create a new blank project, the project should not have an iOS project with code signing set up.expo run:ios -d
and select the physical device.expo run:ios -d
again and you should not be prompted to choose code signing as expo cli will use the preconfigured code signing account. If you open xcode, you should notice that the account you selected is also represented in the Xcode UI.Unit Tests