Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Auto configure TypeScript #3096

Merged
merged 9 commits into from
Jan 21, 2021
Merged

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jan 19, 2021

  • When running expo start, auto detect if TypeScript is in use, then do the following:
    • Verify that the required packages are installed. If not, prompt to install them then try again (disabled in CI).
    • Ensure the tsconfig.json is properly configured.
    • Tell users how to remove TypeScript if they added it by accident (tsconfig.json, TypeScript project files).
  • Feature can be disabled using EXPO_NO_TYPESCRIPT_SETUP=1
  • Detect and use expo/tsconfig.base as the default extends value when it's present (created base tsconfig for expo projects expo#11680).

Test Plan

  • Unit tests
  • Ran in NCL to test that the preset is used
  • Ran in a few complex projects to see if the changes would be annoying.
@EvanBacon EvanBacon marked this pull request as ready for review January 19, 2021 23:48
@EvanBacon EvanBacon merged commit 441dd62 into master Jan 21, 2021
@EvanBacon EvanBacon deleted the @evanbacon/verify-typescript-config branch January 21, 2021 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants